Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix work time check issue when startHour and endHour are the same #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix work time check issue when startHour and endHour are the same #120

wants to merge 2 commits into from

Conversation

alphapku
Copy link

@alphapku alphapku commented Nov 1, 2023

Why

  1. When the startHour and endHour the same, IsWorkTime returns incorrectly

What

  1. Use time.Duration to check if the working time (time of date) is in the range or not.

@rickar
Copy link
Owner

rickar commented Nov 4, 2023

Can you please reapply your changes on top of PR #119 that was just merged?

@alphapku
Copy link
Author

Can you please reapply your changes on top of PR #119 that was just merged?

Sure, done, please check it out. Thanks for your work, again!

@rickar
Copy link
Owner

rickar commented Jan 12, 2024

Can you fix the failing tests please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphapku @rickar